Skip to content

Conversation

@tohanov
Copy link

@tohanov tohanov commented Oct 15, 2025

Super simple typo fix

@avagin
Copy link
Member

avagin commented Oct 15, 2025

Please format the commit message properly. A sign-off email should be a valid email address that can be used to communicate with the author.

@tohanov
Copy link
Author

tohanov commented Oct 16, 2025

Please format the commit message properly. A sign-off email should be a valid email address that can be used to communicate with the author.

I've fixed the email address.
Not sure what you mean by formatting the commit message properly.

@rst0git
Copy link
Member

rst0git commented Oct 18, 2025

@tohanov The following contributor guidelines provide more information on how to format commit messages:

https://github.com/checkpoint-restore/criu/blob/criu-dev/CONTRIBUTING.md

@herheliuk
Copy link
Member

herheliuk commented Oct 20, 2025

@tohanov

Basically you can't do it here on GitHub. (as far as I know)

copy your forked repo to your machine with the following command:

git clone https://github.com/tohanov/criu --branch patch-1

open the folder and run these two commands:

git branch -m patch-1
git remote add origin https://github.com/tohanov/criu

edit last commit:

git commit --amend

e.g. using following format:

[component]: [commit message]

[description]

Signed-off-by: Your Name <developer@example.org>

save & exit with: Ctrl + X, Shift + Y, Enter. I'd do:

cr-restore: typo fix

Changed 'do' to 'does'

Signed-off-by: :| <github-contact.ivy636@passinbox.com>

force push, this should update this PR automatically.

git push origin patch-1 --force

Any questions or issues during the process, you may ask ChatGPT (no login required).

You are very welcome.

@tohanov
Copy link
Author

tohanov commented Oct 25, 2025

I fixed the commit message

@herheliuk
Copy link
Member

@tohanov, you forgot < and > by your email.

Changed 'do' to 'does' in a log message.

Signed-off-by: :| <github-contact.ivy636@passinbox.com>
@tohanov
Copy link
Author

tohanov commented Oct 29, 2025

😅 whoops
Now it's ok hopefully

@avagin
Copy link
Member

avagin commented Oct 30, 2025

Just a reminder: CRIU does not accept contributions from anonymous or pseudonymous individuals. This policy is primarily driven by legal and licensing requirements.

I would prefer to see a verifiable name instead of :|. Currently, this sign-off tag looks suspicious to me, and I would recommend we ignore this minor change.

@avagin avagin marked this pull request as draft October 30, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants