cirrus-ci: add tests for almalinux 8 #2774
Conversation
The phrase "based test" in the task names is not necessary, doesn't provide additional information and makes test names appear longer. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Consolidate common pidfd definitions into a header file and define
missing `__NR_pidfd_open` and `__NR_pidfd_getfd` to fix the following
build errors on AlmaLinux 8:
../lib/pidfd.h:16:17: error: ‘__NR_pidfd_getfd’ undeclared (first use in this function); did you mean ‘pidfd_getfd’?
return syscall(__NR_pidfd_getfd, pidfd, targetfd, flags);
^~~~~~~~~~~~~~~~
pidfd_getfd
pidfd_of_thread.c: In function ‘pidfd_open’:
pidfd_of_thread.c:38:17: error: ‘__NR_pidfd_open’ undeclared (first use in this function); did you mean ‘pidfd_open’?
return syscall(__NR_pidfd_open, pid, flags);
^~~~~~~~~~~~~~~
pidfd_open
In addition, add *.desc files for the pidfd tests so that these
tests are skipped if the kernel does not support pidfd.
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Skip testing amdgpu plugin if libdrm is not installed to
fix the following error:
make[1]: Entering directory '/tmp/criu/plugins/amdgpu'
gcc amdgpu_plugin_topology.c tests/test_topology_remap.c -o test_topology_remap -DCOMPILE_TESTS -iquote../../include -iquote../../criu/include -iquote../../criu/arch//include/ -iquote../../ -I .
In file included from amdgpu_plugin_topology.c:18:
kfd_ioctl.h:26:10: fatal error: libdrm/drm.h: No such file or directory
#include <libdrm/drm.h>
^~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:39: test_topology_remap] Error 1
make[1]: Leaving directory '/tmp/criu/plugins/amdgpu'
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
The CI tests for CentOS 8 have been removed as it is EOL. This patch adds AlmaLinux task in Cirrus-CI as a replacement for these tests to build and test CRIU in RHEL 8–compatible environment. Suggested-by: Adrian Reber <areber@redhat.com> Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
|
@rst0git rhel8 reached the eol. I don't think that we need to continue testing it and all its derivatives. |
CentOS Stream 8 is EOL. RHEL 8 and clones are available and supported at least until 2029. |
https://access.redhat.com/support/policy/updates/errata#RHEL8_Planning_Guide |
https://wiki.almalinux.org/release-notes/ Any one, who decided to stay on them after the end of the active support, should not want to use the new CRIU version. Seriously, let's stop testing them. There is no reason to support (add hacks) 7+ years old kernels. |
| @@ -0,0 +1,26 @@ | |||
| #ifndef __NR_pidfd_open | |||
| #define __NR_pidfd_open 434 | |||
|
Thanks Andrei! EPEL 8 is still one of the most used repositories: We often backport kernel patches to fix CVEs in RHEL 8, and the same patches are included in AlmaLinux as it maintains binary compatibility. Some of these patches break CRIU and we need to keep updating the package: |
|
@rst0git yeah, this sort of vulnerabilities is one in decade.... btw this case was caught by other jobs and rhel8 jobs had no effect how it was fixed. As I said, I don't like the idea of supporting ancient kernels. If we really want to run these tests, we can create a separate branch with the rhel8 criu version that will run tests on Almalinux once a day. |
Thank you for the suggestion. I will close this pull request for now as I'm not sure how many people actually use CRIU on RHEL 8 / AlmaLinux 8. |
4 participants
The CI tests for CentOS 8 have been removed as it is EOL. This pull request adds AlmaLinux task in Cirrus-CI as a replacement for these tests to build and test CRIU in RHEL 8–compatible environment.