Skip to content

Add configurable breakpoint control for restore path #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add configurable breakpoint control for restore path #2729

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe4745e
Initial plan
Copilot Sep 5, 2025
2779a64
Disable breakpoints on the restore path
Copilot Sep 5, 2025
c4c90e4
Add --enable-restore-breakpoints command line flag
Copilot Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion criu/cr-restore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,7 +1820,7 @@ static int restore_rseq_cs(void)
static int catch_tasks(bool root_seized)
{
struct pstree_item *item;
bool nobp = fault_injected(FI_NO_BREAKPOINTS) || !kdat.has_breakpoints;
bool nobp = true; /* Always disable breakpoints on the restore path */
Copy link
Member

@avagin avagin Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a command line flag to disable it optionaly

Copy link
Member

@avagin avagin Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot pls add a command line flag to disable it optionaly

Copy link
Author

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the --enable-restore-breakpoints command line flag as requested. By default, breakpoints remain disabled on restore for reliability (maintaining current behavior). When the flag is provided, the restore operation will use the original logic that respects hardware capabilities and fault injection settings. Commit c4c90e4


for_each_pstree_item(item) {
int status, i, ret;
Expand Down
Loading