Refactor offloading watermark and add watermark in metrics collection job #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te related methods for improved clarity and consistency
leo-marble
force-pushed
the
mar-1132-refactor-the-offloading_watermark
branch
2 times, most recently
from
b0f8ece to
9ea9d5c
Compare
leo-marble
force-pushed
the
mar-1132-refactor-the-offloading_watermark
branch
from
9ea9d5c to
348a092
Compare
leo-marble
force-pushed
the
mar-1132-refactor-the-offloading_watermark
branch
from
348a092 to
fe4ef00
Compare
leo-marble
commented
Jul 3, 2025
| } | ||
| } | ||
|
|
||
| // HELP: Not sure about raising the error here |
There was a problem hiding this comment.
Don't know how to deal with the error
There was a problem hiding this comment.
I think returning an error is correct. it would happen if the function was passed a global watermark instead of a decision rules one. Maybe we can clarify the error to reflect that.
There was a problem hiding this comment.
I will fix it in #1071 after rebase
apognu
approved these changes
Jul 4, 2025
apognu
reviewed
Jul 4, 2025
| CreatedAt time.Time | ||
| UpdatedAt time.Time | ||
| Params *json.RawMessage |
There was a problem hiding this comment.
json.RawMessage is a []byte underneath, so it can already be nil. I don't think we need the extra indirection here.
There was a problem hiding this comment.
I will remove the pointer in #1071 after rebase.
Thanks
leo-marble
merged commit 554b18b
into
mar-1129-define-the-collectdata-logic
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
offloading_watermarktable to be renamed towatermark. This change allows us to move away from the specific offloading use case and makes the table more generic.Additionally, this PR introduces the concept of watermarking in the metric collection system to provide a reference for the lower bound on dates. The param attribute allows adding extra parameters based on the type of watermark if the existing fields are insufficient. I introduce the notion of watermark
typeI have ensured that the same fields as in the offloading table are retained, although some field names have been changed for clarity and consistency.
The migration process is done in two steps:
During the migration, the table is locked to prevent any access and ensure data integrity.
Additionally, this PR introduces the concept of watermarking in the metric collection system to provide a reference for the lower bound on dates.