Correct examples in readme and values.yaml #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelbicskei
requested review from
SDawley,
dkwon17,
ibuziuk and
tolusha
as code owners
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON string value in values.yaml has to be escaped for Helm to function correctly. I actually preferred we changed the whole values.yaml to consistent YAML and use the Helm templating engine to encode into JSON for the configMap data..
This will be a braking change tho, so looking for the opinion of the maintainers.