feat: Add deployment tolerations and nodeselector

[ianbabysre]

I'm opening a PR to add a feature to the deployment :

This feature adds the following

Possibility to set a tolerations and/or nodeSelector to the Deployment

I tested it, see screenshot

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Click here to review and test in web IDE:

[tolusha]

@ianbabysre
Thank you for contribution, could you provide values.yaml you used for testing ?

[ianbabysre]

Sure thing ! I tested the templating using by setting theses values in values.yaml
Then used helm template -f values.yaml --debug . for templating

nodeSelector:
  dedicated: compute
tolerations:
  - key: dedicated
  operator: Equal
  value: Compute
  effect: NoSchedule

I left empty values by default

[ianbabysre]

@tolusha Let me know if that's okay with you or not !

[tolusha]

Hi.
Unfortunately I failed to deploy helmcharts, could you double check please?

-> % helm install kubernetes-image-puller deploy/helm -n n9
Error: INSTALLATION FAILED: 1 error occurred:
	* Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal object into Go struct field PodSpec.spec.template.spec.tolerations of type []v1.Toleration

values.yaml

tolerations:
  - key: dedicated
    operator: Equal
    value: Compute
    effect: NoSchedule

[github-actions]

Click here to review and test in web IDE:

[ianbabysre]

@tolusha Silly mistake on my end sorry, it should work correctly now. - I installed it the same way you did.
Let me know if that work on your end

[tolusha]

Sounds good.

[devspacesbuild]

Build 3.20 :: imagepuller_3.x/152: Console, Changes, Git Data

[devspacesbuild]

Build 3.20 :: sync-to-downstream_3.x/8798: Console, Changes, Git Data

[devspacesbuild]

Build 3.20 :: get-sources-rhpkg-container-build_3.x/8916: Console, Changes, Git Data

[devspacesbuild]

Build 3.20 :: get-sources-rhpkg-container-build_3.x/8916:

imagepuller : 3.x :: Failed in 66726190 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

[ianbabysre]

@tolusha Thanks a lot ! Have a great day