feat: Update chart to allow updateStrategy to be parameterized #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbabysre
requested review from
SDawley,
dkwon17,
ibuziuk and
tolusha
as code owners
|
Click here to review and test in web IDE: |
tolusha
approved these changes
Jan 24, 2025
|
@dkwon17 Any concerns ? |
|
@ianbabysre |
|
Click here to review and test in web IDE: |
1 similar comment
|
Click here to review and test in web IDE: |
|
@tolusha It's updated ! Sorry for the delay |
ianbabysre
force-pushed
the
allow-different-strategy
branch
from
df47405 to
29b3f7d
Compare
|
Click here to review and test in web IDE: |
ianbabysre
force-pushed
the
allow-different-strategy
branch
from
29b3f7d to
00d17e3
Compare
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
@tolusha i fixed the conflit and will do the same for the PR about tolerations and nodeSelector if you decide to accept this one ! Thank you for being so quick by the way ! |
|
Build 3.20 :: imagepuller_3.x/151: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8773: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8891: imagepuller : 3.x :: Failed in 66701147 : BREW:BUILD/STATUS:UNKNOWN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone
I'm opening a PR to update the chart and allow the updateStrategy of the Deployment to be configured.
This feature adds the following
Possibility to set a updateStrategy type to the Deployment. I left Recreate by default which what was in the chart
Let me know what you think.