Skip to content

Add RowsAffected implementation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Add RowsAffected implementation #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions chdb/driver/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ func (r *singleRow) Err() error {
}

type execResult struct {
err error
localRes chdbpurego.ChdbResult
err error
}

func (e *execResult) LastInsertId() (int64, error) {
Expand All @@ -122,7 +123,8 @@ func (e *execResult) RowsAffected() (int64, error) {
if e.err != nil {
return 0, e.err
}
return -1, fmt.Errorf("does not support RowsAffected")
// chdb return the number of rows inserted/updated/deleted trough rows_read
return int64(e.localRes.RowsRead()), nil
}

type queryHandle func(string, ...string) (chdbpurego.ChdbResult, error)
Expand Down Expand Up @@ -283,12 +285,17 @@ func (c *conn) Exec(query string, values []driver.Value) (sql.Result, error) {
}

func (c *conn) ExecContext(ctx context.Context, query string, args []driver.NamedValue) (driver.Result, error) {
_, err := c.QueryContext(ctx, query, args)
if err != nil && err.Error() != "result is nil" {
compiledQuery, err := c.compileArguments(query, args)
if err != nil {
return nil, err
}
result, err := c.QueryFun(compiledQuery, c.driverType.String(), c.udfPath)
if err != nil {
return nil, err
}
return &execResult{
err: nil,
err: nil,
localRes: result,
}, nil
}

Expand Down