Skip to content

chore(cargo): upgrade async_zip to 0.0.17 #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Oct 10, 2024

No description provided.

@link2xt link2xt force-pushed the link2xt/update-async-zip branch from 740fa47 to 38be352 Compare October 10, 2024 11:14
@link2xt
Copy link
Collaborator Author

link2xt commented Oct 10, 2024

This also updates async-compression, so would be nice to merge before #5990 to avoid duplicate dependencies.

@link2xt link2xt force-pushed the link2xt/update-async-zip branch from 38be352 to dd125f1 Compare October 10, 2024 13:47
@link2xt link2xt requested a review from r10s October 10, 2024 13:50
src/webxdc.rs Outdated
@@ -235,7 +234,7 @@ impl Context {
bail!("{} is not a valid webxdc file", filename);
}

let valid = match async_zip::read::fs::ZipFileReader::new(path).await {
let valid = match async_zip::tokio::read::fs::ZipFileReader::new(path).await {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use async_zip::tokio::read::fs::ZipFileReader as FsZipFileReader?

@link2xt link2xt merged commit 19be12a into main Oct 11, 2024
36 of 37 checks passed
@link2xt link2xt deleted the link2xt/update-async-zip branch October 11, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants