-
Notifications
You must be signed in to change notification settings - Fork 359
Upgrade dependencies and implementation of the integration test #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should ve testing both?
Chart.js 3 and 4? |
Yes, or was v3 support already droped? |
V3 should be supported, version 3.7.0 |
I will work tomorrow on that. I think we need a package.json template to update at runtime, settimg v3 and then v4. I need to see how the fs api in js are working |
Its already running for each of the ts versions, should not be hard to add another loop for that. Or just split to separate folders (and maybe test only some of the later ts versions with v4) |
@kurkle I have done! Have a look if ok.
|
Must be rebased when #838 will be merged. Now in draft |
Many lines of code to avoid adding a chart.js major once a year or two? :) |
Another thought, maybe this one should be converted to pnpm too, so it could use workspace dependencies and avoid the temporary directory stuff. Like its done in chart.js now. |
I could agree. For my mindset, I'm never afraid about maintenance or LoC ;)
OK! for this one, I need more time to have a look how it works with more details that I have got now. |
Close for now |
This PR is changing the dependency with CHART.JS, going to version4. It's also adding the test on TS 4.7.x