Skip to content

Add external links to release note/drafter #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Add external links to release note/drafter #762

merged 5 commits into from
Jun 8, 2022

Conversation

stockiNail
Copy link
Collaborator

Adds to release note/drafter the following links:

  • documentation
  • migration guide (v2)
  • samples

to keep it aligned to Chart.js format.

@stockiNail stockiNail added this to the 2.0.0 milestone Jun 8, 2022
@stockiNail stockiNail requested a review from LeeLenaleee June 8, 2022 14:17
Co-authored-by: Jacco van den Berg <39033624+LeeLenaleee@users.noreply.github.com>
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee I was stupid because I had seen in chartjs that sequence but I have decided to change it... don't ask why.

@LeeLenaleee
Copy link
Collaborator

np, np :)
Maby we should also add typedoc to the documentation. Then we have all the links chart.js also has in its release drafter. But that is something for another PR and low prio

@stockiNail
Copy link
Collaborator Author

np, np :) Maby we should also add typedoc to the documentation. Then we have all the links chart.js also has in its release drafter. But that is something for another PR and low prio

@LeeLenaleee Yes, I agree 100%.

Off topic: I was thinking that maybe we should release version 2. in this #755 (comment) I have shared my standpoint about missing things.

With this PR, remains:

  1. #749 raises a doubt about the clip on box for label. If the proposal will be accepted, we have a breaking change and therefore another PR to add it in the migration guide is required
  2. currently events options, commons for all annotation, are managed at root level of plugin options. Now with common node, maybe it makes sense to move over there, like all other annotation options. This would be a breaking change.

Item 2 can be ignored and we will see in version 3.

What do you think?

@stockiNail stockiNail merged commit bbc6b13 into chartjs:master Jun 8, 2022
@stockiNail stockiNail deleted the addExternalLinksToReleaseDrafter branch June 8, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants