Skip to content

Update line annotation diagram to describe new element structure #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2022
Merged

Update line annotation diagram to describe new element structure #752

merged 2 commits into from
May 31, 2022

Conversation

stockiNail
Copy link
Collaborator

Removes the wrong line label element diagram because not updated to new structure.

@stockiNail stockiNail added this to the 2.0.0 milestone May 25, 2022
@stockiNail stockiNail requested review from kurkle and LeeLenaleee May 31, 2022 14:42
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line: The following diagram is showing the element properties about a 'line' annotation: and the inner label:

Should now be: The following diagram is showing the element properties about a 'line' annotation:

Can be found at line number 80

@stockiNail
Copy link
Collaborator Author

The line: The following diagram is showing the element properties about a 'line' annotation: and the inner label:

Should now be: The following diagram is showing the element properties about a 'line' annotation:

Can be found at line number 80

Yeah, forgot to remove it.

@stockiNail stockiNail merged commit a23868c into chartjs:master May 31, 2022
@stockiNail stockiNail deleted the fixMigrationDiagram branch May 31, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants