-
Notifications
You must be signed in to change notification settings - Fork 360
Add z option to all annotations #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small things
Changing the function name, we have re-enabled code climate issue about cognitive complexity. 😟 |
@LeeLenaleee apologize, I have tried to solve CC issue about complexity (I think better to have an exception as was before) and your approval is dismissed. |
np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat unrelated comment: Would be nice to normalize the common properties somehow, rather documenting for each annotation type.
Are you thinking a common MD file to import in each page or a specific page with common options? |
Common MD file that gets imported would be better, would be more in line with chart.js itself and will make it more user frienndly because people will only go to the place they are using and prob won't see the common page |
OK! The content for the next PR is already decided! ;) |
Fix #175
This PR is adding new option to all annotations and their label subelements in order to enable the user to define which annotations should be drawn on top, with the same
drawTime
.