Skip to content

Add z option to all annotations #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2022
Merged

Add z option to all annotations #738

merged 6 commits into from
May 19, 2022

Conversation

stockiNail
Copy link
Collaborator

Fix #175

This PR is adding new option to all annotations and their label subelements in order to enable the user to define which annotations should be drawn on top, with the same drawTime.

@stockiNail stockiNail added this to the 2.0.0 milestone May 16, 2022
@stockiNail stockiNail marked this pull request as draft May 16, 2022 16:46
@stockiNail stockiNail marked this pull request as ready for review May 16, 2022 17:21
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things

@stockiNail
Copy link
Collaborator Author

Changing the function name, we have re-enabled code climate issue about cognitive complexity. 😟

LeeLenaleee
LeeLenaleee previously approved these changes May 17, 2022
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee apologize, I have tried to solve CC issue about complexity (I think better to have an exception as was before) and your approval is dismissed.

@LeeLenaleee
Copy link
Collaborator

np

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat unrelated comment: Would be nice to normalize the common properties somehow, rather documenting for each annotation type.

@stockiNail
Copy link
Collaborator Author

Somewhat unrelated comment: Would be nice to normalize the common properties somehow, rather documenting for each annotation type.

Are you thinking a common MD file to import in each page or a specific page with common options?

@LeeLenaleee
Copy link
Collaborator

Common MD file that gets imported would be better, would be more in line with chart.js itself and will make it more user frienndly because people will only go to the place they are using and prob won't see the common page

@stockiNail
Copy link
Collaborator Author

Common MD file that gets imported would be better, would be more in line with chart.js itself and will make it more user frienndly because people will only go to the place they are using and prob won't see the common page

OK! The content for the next PR is already decided! ;)

@stockiNail stockiNail merged commit 0e68647 into chartjs:master May 19, 2022
@stockiNail stockiNail deleted the zOption branch May 19, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Annotation z-index
3 participants