-
Notifications
You must be signed in to change notification settings - Fork 360
Use scale defined in the chart when x/y ScaleID options are not set #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just couple of comments / questions,
If we will start going to V2 and due to element normalization, maybe it could be helpful to define the sequence of PR merging in order to help the rebasing, where needed. My 2 cents. |
I think that would be your task, because you've done all the work. So maybe just keep things as draft and mark the next one ready after merge. |
Fine for me. In fact, they are all in Draft, apart of the V2 migration page one which must be the first one. |
Fix #676
This PR removes the
x/yScaleID
options defaults from annotation. It will use the scale (defined as x or y) in the chart and only when 1 scale for the coordinate is defined.TODO