Skip to content

Soql and Design changes #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2024
Merged

Conversation

Sreshtag
Copy link
Contributor

@Sreshtag Sreshtag commented Nov 10, 2024

Changes Made

  1. utilityVariables.cls -> Included the regex for SOQL_EXECUTE_BEGIN , SOQL_EXECUTE_END
  2. SoqlUtility.cls -> added condtions to add soql begin and exit
  3. LogLineWrapper.js -> Added condtional styling class SOQLB & SOQLE
  4. LogLineWrapper.css -> added styling class SOQLB & SOQLE for color in Detailed log viewer
  5. Added Navbar and some small design changes in components.
    nav

@charangirijala
Please review the changes

@charangirijala charangirijala added the enhancement New feature or request label Nov 10, 2024
@charangirijala
Copy link
Owner

Hello @Sreshtag

Can you plz add screeshots of the 2 soql statemnts in the detailed log viewer

@Sreshtag
Copy link
Contributor Author

Sreshtag commented Nov 10, 2024

Hi @charangirijala
PFA
soql

//<!-- SOQLB -->
else if (logTemp.logLineData.type === "SOQLB") {
logTemp.eventClassComb = "slds-line-clamp soqb";
console.log("Query: ", JSON.stringify(logTemp.logLineData));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz comment this line

//<!-- SOQLE -->
else if (logTemp.logLineData.type === "SOQLE") {
logTemp.eventClassComb = "slds-line-clamp soqe";
console.log("No.of Rows: ", JSON.stringify(logTemp.logLineData));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz comment this line

* 1. Use same methods as METHOD_ENTRY
* 2. Process all details and call METHOD_ENTRY methods
*/
SoqlUtility.processSoqlbegin(line,eventInfo.get(regex));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pass single parameter line as we only have single regex pattern is not required

/*
* 1. Use same methods as METHOD_EXIT
*/
SoqlUtility.processSoqlExit(line,eventInfo.get(regex));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pass single parameter line as we only have single regex pattern is not required

@charangirijala charangirijala merged commit bac5dfd into charangirijala:main Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants