Skip to content

Conversation

aganders3
Copy link
Contributor

@aganders3 aganders3 commented Jan 14, 2025

Description

This removes the check with npe2api for "active" plugins that prevents plugins from being marked stale. The check was made redundant by #1331. This closes #1334, because relevant plugins (those already in Dynamo with matching non-normalized names on npe2api/plugins) will now be marked "stale" and removed from the public view of the hub.

@aganders3 aganders3 requested a review from manasaV3 January 14, 2025 02:20
@aganders3 aganders3 added the bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes label Jan 14, 2025
@aganders3
Copy link
Contributor Author

I'm not sure why the Push Remote Dev workflow is failing. It looks okay to me in Terraform.

@aganders3 aganders3 changed the title Ensure pypi-normalized names when fetching from npe2api Remove redundant check for "active" plugins on npe2api Jan 21, 2025
Comment on lines -45 to -50
if pypi_plugin_version is None and is_plugin_active(name, version):
logger.info(
f"Skipping marking plugin={name} version={version} stale as the "
f"plugin is still active in npe2api"
)
continue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main feature of this PR. This should result in removal of the duplicate plugins we were seeing on prod.

@aganders3 aganders3 requested a review from manasaV3 January 21, 2025 15:37
Copy link
Collaborator

@manasaV3 manasaV3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aganders3 aganders3 merged commit d132994 into main Jan 27, 2025
9 checks passed
@aganders3 aganders3 deleted the fix-duplicate-plugins-name-normalization branch January 27, 2025 19:47
@github-actions
Copy link

This PR has been included in release: v25.01.1, see the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate plugin entries

2 participants