-
Notifications
You must be signed in to change notification settings - Fork 2
v1.4.8-testnet #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
v1.4.8-testnet #74
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -4,8 +4,8 @@ RUN adduser --disabled-password --gecos "" --no-create-home --uid 1000 cronos | |||||||||||||||||||||||
|
||||||||||||||||||||||||
RUN mkdir -p /home/cronos/data && mkdir -p /home/cronos/config | ||||||||||||||||||||||||
RUN apt-get update -y && apt-get install wget curl procps net-tools jq lz4 -y | ||||||||||||||||||||||||
RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.7/cronos_1.4.7_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.7_Linux_x86_64.tar.gz \ | ||||||||||||||||||||||||
&& rm cronos_1.4.7_Linux_x86_64.tar.gz && mv ./* /home/cronos/ | ||||||||||||||||||||||||
RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.8/cronos_1.4.8-testnet_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.8-testnet_Linux_x86_64.tar.gz \ | ||||||||||||||||||||||||
&& rm cronos_1.4.8-testnet_Linux_x86_64.tar.gz && mv ./* /home/cronos/ | ||||||||||||||||||||||||
Comment on lines
+7
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion ENTRYPOINT path mismatch – container may not start With the corrected move, -ENTRYPOINT ["/home/cronos/bin/cronosd"]
+ENTRYPOINT ["/home/cronos/cronosd"]
# or preserve hierarchy:
+# RUN mv cronos_1.4.8-testnet_Linux_x86_64/bin/* /home/cronos/bin/ 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Checkov (3.2.334)[HIGH] 7-8: Ensure that certificate validation isn't disabled with wget (CKV2_DOCKER_3) 🤖 Prompt for AI Agents
|
||||||||||||||||||||||||
RUN chown -R cronos:cronos /home/cronos && chmod 1777 /tmp | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
USER root | ||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Wildcard
mv ./*
may relocate unrelated /tmp filesAfter extraction,
mv ./* /home/cronos/
moves everything currently in/tmp
, which can unintentionally include unrelated temporary artefacts. Limit the move to the extracted directory contents:📝 Committable suggestion
🧰 Tools
🪛 Checkov (3.2.334)
[HIGH] 7-8: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
🤖 Prompt for AI Agents