add basic support for .ase/.aseprite files from LibreSprite and Aseprite #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull solves the #189 issue.
I add a basic support for .ase/.aseprite files. The header check is strict enough to identify the files well. I used data_check_size and file_check_size_min without any special data or final file validation.
RECOMENDATION: Run .ase/.aseprite on photorec expert mode using the smallest blocksize (512). Once simple .ase/.aseprite files can be really small (<1KB).
You can see docs and specs about the .ase/.aseprite files following the issue description.
Important to comment that the first version of this feat had a bug where (because the lack of a data_check function) photorec couldn't determine well the end of file, resulting in unnecessary big files (1MB, 512MB, or even Gigabytes). Running the photorec with that bug almost fulfilled my disk. After that, even running the fixed version or even running on expert mode with smallest blocksize just bring me back the same recovered files, again and again. I expect it to be just an issue with my disk after running that bug version that almost fulfilled it.
test recording (with the commented bug, but recovery working)
I hope I did it well 🙏🏽.