-
Notifications
You must be signed in to change notification settings - Fork 190
ENT-8096: Policy profiler in cf-agent #5901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Changelog: The policy profiling logic is now implemented natively within the cf-agent, replacing the previous reliance on cf-agent logs and the cf-profile.pl script for faster execution. Ticket: ENT-8096 Signed-off-by: Victor Moene <victor.moene@northern.tech>
} | ||
VariableTableIteratorDestroy(iter); | ||
} | ||
EvalContextPushEvent(ctx, EventFrameNew("bundle", owner->name, owner->ns, GetAbsolutePath(owner->source_path), owner->offset)); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
} | ||
VariableTableIteratorDestroy(iter); | ||
} | ||
EvalContextPushEvent(ctx, EventFrameNew("bundle", owner->name, owner->ns, GetAbsolutePath(owner->source_path), owner->offset)); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
} | ||
VariableTableIteratorDestroy(iter); | ||
} | ||
EvalContextPushEvent(ctx, EventFrameNew("bundle", owner->name, owner->ns, GetAbsolutePath(owner->source_path), owner->offset)); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
} | ||
VariableTableIteratorDestroy(iter); | ||
} | ||
EvalContextPushEvent(ctx, EventFrameNew("bundle", owner->name, owner->ns, GetAbsolutePath(owner->source_path), owner->offset)); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
} | ||
} | ||
|
||
EvalContextPushEvent(ctx, EventFrameNew("promise", PromiseGetPromiseType(owner), PromiseGetNamespace(owner), "null", owner->offset)); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
|
||
if (SeqLength(ctx->event_stack) < 1) | ||
{ | ||
ctx->root = popped; |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
|
||
void EvalContextEventStackClear(EvalContext *ctx) | ||
{ | ||
// SeqClear(ctx->event_stack); |
Check notice
Code scanning / CodeQL
Commented-out code Note
void EvalContextEventStackClear(EvalContext *ctx) | ||
{ | ||
// SeqClear(ctx->event_stack); | ||
ctx->event_stack = SeqNew(10, NULL); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
|
||
void EvalContextPrintRoot(EvalContext *ctx) | ||
{ | ||
EventFrameTraverse(ctx->root, 0); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
WriterClose(fncall_writer); | ||
} | ||
|
||
EvalContextPushEvent(ctx, EventFrameNew("function", fp->name, PromiseGetNamespace(fp->caller), "null", fp->caller->offset)); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
No description provided.