ENT-10184: Top down evaluation #5834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victormlg
force-pushed
the
top-down-evaluation
branch
from
51e4721 to
c255477
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victormlg
force-pushed
the
top-down-evaluation
branch
4 times, most recently
from
eccfbbf to
29b776d
Compare
victormlg
force-pushed
the
top-down-evaluation
branch
4 times, most recently
from
a66b123 to
5038b0c
Compare
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
victormlg
force-pushed
the
top-down-evaluation
branch
from
a76ce54 to
1f0e9b7
Compare
victormlg
force-pushed
the
top-down-evaluation
branch
from
1f0e9b7 to
b1b9bad
Compare
victormlg
force-pushed
the
top-down-evaluation
branch
3 times, most recently
from
f9a9ac0 to
599311a
Compare
Ticket: ENT-10184 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
top-down-evaluation
branch
from
599311a to
797bed8
Compare
| @@ -1452,6 +1454,7 @@ | |||
| } | |||
|
|
|||
| SeqAppend(section->promises, pp); | |||
| SeqAppend(section->parent_bundle->all_promises, pp); | |||
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
Signed-off-by: Victor Moene <victor.moene@northern.tech>
olehermanse
reviewed
Jul 4, 2025
olehermanse
reviewed
Jul 4, 2025
| elif self._validator_attributes[name]["typing"] is int: | ||
| try: | ||
| replacements[name] = int(value) | ||
| except ValueError: |
Check notice
Code scanning / CodeQL
Empty except Note test
victormlg
force-pushed
the
top-down-evaluation
branch
2 times, most recently
from
fd5b98b to
cd37f33
Compare
olehermanse
reviewed
Jul 14, 2025
olehermanse
reviewed
Jul 14, 2025
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
top-down-evaluation
branch
from
cd37f33 to
1dcceca
Compare
|
@cf-bottom jenkins, please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12355/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12355/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.