Skip to content

Define the "suse" class on SLED systems #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Define the "suse" class on SLED systems #5773

wants to merge 1 commit into from

Conversation

amousset
Copy link
Contributor

@amousset amousset commented Apr 18, 2025 •
edited
Loading

When running the agent on a SLED (SUSE Linux Enterprise Desktop), we get:

CFEngine(common)  Operating System not properly recognized, setting sys.os_name_human to "Unknown", please submit a bug report for us to fix this

This is caused by the OS detection skipping the suse alias on SLED systems.

@amousset amousset force-pushed the sled-suse-alias branch 3 times, most recently from 1fb322a to f859b1c Compare April 18, 2025 09:52
@amousset amousset changed the title Define suse class on SLED systems Define the "suse" class on SLED systems Apr 18, 2025
@cf-bottom
Copy link

Thanks for submitting a PR! Maybe @larsewi can review this?

craigcomstock
craigcomstock approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable!

craigcomstock
craigcomstock requested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are in the middle of releasing new version so are in a code freeze.

Will merge after release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcomstock craigcomstock craigcomstock requested changes

@larsewi larsewi Awaiting requested review from larsewi

@nickanderson nickanderson Awaiting requested review from nickanderson

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
after-release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amousset @cf-bottom @craigcomstock