build-scripts/functions: added logging functions #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsewi
force-pushed
the
logging
branch
2 times, most recently
from
7e26800 to
43c7eb5
Compare
The main motivation for these functions is for them to include the filename in the output. Hence, when things stop working, you'll know exactly where to look. Example file: ```sh . "$(dirname "$0")/functions" log_debug foo bar baz log_error bogus ``` Example output: ``` $ ./test.sh test.sh: Debug: foo bar baz test.sh: Error: bogus ``` Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
olehermanse
approved these changes
Jul 24, 2025
|
GH Actions failure is unrelated. |
vpodzime
approved these changes
Jul 24, 2025
| @@ -617,4 +617,14 @@ run_and_print_on_failure() | |||
| return $exit_code | |||
| } | |||
|
|
|||
| log_debug() | |||
| { | |||
| echo "$(basename "$0"): Debug:" "$@" | |||
There was a problem hiding this comment.
I'd do lowercase debug: and error: as that's more common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for these functions is for them to include the
filename in the output. Hence, when things stop working, you'll know
exactly where to look.
Example file:
Example output:
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech