Fix JLCPCB files + add documentation about ordering #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instructions and update bom files with new components
|
Just tested this, thanks! Great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Came to this project from the ESPHome documentation for the Kamstrup Meter Protocol, when trying to order I had issues with the BOM matching components.
Looking at the repo I found issue #3 where I found instructions how to fix this. I've updated the BOM and position files for JLCPCB so that all the components are identified automatically + the transistors are oriented correctly.
I've also added another README to the Electronics folder. This contains some basic instructions about ordering the PCB.
This merge closes issue #3 and Pull Request #4
Please let me know if something is lacking in the documentation!