Added Shodan Alert API Collector #2618
Conversation
sebix
added
feature
|
test will succeed with #2619 |
| raise ValueError("Library 'shodan' is needed but not installed.") | ||
|
|
||
| self.set_request_parameters() | ||
| if tuple(int(v) for v in pkg_resources.get_distribution("shodan").version.split('.')) <= (1, 8, 1): |
There was a problem hiding this comment.
- Looks like
pkg_resourcesis not imported - It's deprecated anyway, and will be gone soon, please use replacements
There was a problem hiding this comment.
- Let's add this check to
checkmethod
There was a problem hiding this comment.
IntelMQ uses pkg_resources a lot, so to get rid of it, we will need to change a few more code lines.
For the sake of consistency and not to introduce deviant code, I'd like to keep pkg_resources here.
There was a problem hiding this comment.
Let's add this check to
checkmethod
Good idea, but the static check method can't call the non-static self.set_request_parameters() which processes and provides the proxy parameters :/
There was a problem hiding this comment.
But you don't need proxy to check the library version, just extract checking to a static method. Or is there a kind of import/patching race condition?
sebix
force-pushed
the
shodan-alert
branch
5 times, most recently
from
c5de2cf to
059adfc
Compare
|
I don't yet know what causes the tests fail about the EDIT: Yep, was exactly that 🙈 |
sebix
force-pushed
the
shodan-alert
branch
3 times, most recently
from
4820306 to
25fd943
Compare
In cooperation with Malawi CERT
Created in cooperation with Malawi CERT