Skip to content

Drop support for Python 3.8 #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Drop support for Python 3.8 #2617

merged 2 commits into from
May 15, 2025

Conversation

sebix
Copy link
Member

@sebix sebix commented May 14, 2025

it's EOL since 2024-10 and it's no longer in use by a supported plattform

Upgrade code with pyupgrade --py39-plus

The trigger for the change is #2615 and pymssql/pymssql#937

@sebix sebix added this to the 3.4.1 Patch release milestone May 14, 2025
@sebix sebix requested a review from kamil-certat May 14, 2025 07:22
@sebix sebix force-pushed the drop-3.8 branch 2 times, most recently from f512c5d to 95b9c38 Compare May 14, 2025 07:25
Copy link
Contributor

@kamil-certat kamil-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've missed the Python requirements in Debian package: https://github.com/certtools/intelmq/blob/2f15e20422d350f6ac4cfa641d89712f7f306d7c/debian/control#L28C1-L28C26

And please prepare similar changes for other components

@aaronkaplan I think you have to approve/change in the Repo config that CI for 3.8 is no longer requiered

sebix added 2 commits May 15, 2025 08:28
it's EOL since 2024-10 and it's no longer in use by a supported
plattform

fixes certtools#2616
@sebix
Copy link
Member Author

sebix commented May 15, 2025

You've missed the Python requirements in Debian package: https://github.com/certtools/intelmq/blob/2f15e20422d350f6ac4cfa641d89712f7f306d7c/debian/control#L28C1-L28C26

Thanks, added that change.

@aaronkaplan aaronkaplan merged commit 536b91a into certtools:develop May 15, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants