Skip to content

ctl run: fix overwriting logging level #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Conversation

sebix
Copy link
Member

@sebix sebix commented Apr 17, 2025

Fix overwriting the runtime logging level by command line parameter implemented by proper mocking

@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: intelmqctl labels Apr 17, 2025
@sebix sebix added this to the 3.4.1 Patch release milestone Apr 17, 2025
@sebix sebix requested a review from kamil-certat April 17, 2025 12:34
@sebix sebix force-pushed the fix-2563 branch 2 times, most recently from 09e9116 to 80820d2 Compare April 17, 2025 13:42
@sebix sebix linked an issue Apr 24, 2025 that may be closed by this pull request
@sebix
Copy link
Member Author

sebix commented Apr 28, 2025

Rebased to fix the tests

Copy link
Contributor

@kamil-certat kamil-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually prefer when we add an overriding option to the bot class, but it looks reasonable as well.

Fix overwriting the runtime logging level by command line parameter
implemented by proper mocking

fixes certtools#2563
@sebix sebix merged commit fb15619 into certtools:develop Jul 17, 2025
20 checks passed
@sebix sebix deleted the fix-2563 branch July 17, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ctl: interactive run ignores custom log level
2 participants