PostgreSQL: use JSONB for extra column #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-certat
approved these changes
Apr 14, 2025
sebix
commented
Apr 22, 2025
intelmq/bin/intelmq_psql_initdb.py
Outdated
| @@ -213,8 +213,8 @@ def main(): | |||
| help="Path to the harmonization file") | |||
| parser.add_argument("--skip-or-replace", default=False, action="store_true", | |||
| help="Add IF NOT EXISTS or REPLACE directive to created schemas") | |||
| parser.add_argument("--jsonb", default=False, action="store_true", | |||
| help="Use JSONB type to represent dictionary fields") | |||
| parser.add_argument("--no-jsonb", default=True, action="store_true", | |||
There was a problem hiding this comment.
Found by @th-certbund: default should be False
sebix
changed the title
|
Also added an Merging blocked by #2602 |
wagner-intevation
added a commit
to Intevation/intelmq-mailgen
that referenced
this pull request
Apr 24, 2025
IntelMQ's eventdb events.extra switched from type JSON to JSONB: certtools/intelmq#2597 directly use the JSONB type in the functions
Postgres supports it since version 9, IntelMQ should have defaulted to it since then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres supports it since version 9, IntelMQ should have defaulted to it since then