Skip to content

Recommend reloader instead of wave, as that seems to no longer be maintained #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2025
Merged

Recommend reloader instead of wave, as that seems to no longer be maintained #1801

merged 3 commits into from
Oct 13, 2025

Conversation

@sdahlbac
Copy link
Contributor

Recommend reloader instead of wave.

Fixes cert-manager/cert-manager#8155

❓ should I have been changing the text in the old doc versions too?

@sdahlbac
Recommend reloader instead of wave, as that seems to no longer be mai…
6a4e742 
…ntained

Signed-off-by: Simon Dahlbacka <simon.dahlbacka@fellowmind.fi>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2025
@netlify
Copy link

netlify bot commented Oct 10, 2025 •
edited
Loading

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 130aa10
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/68ec9ede09972200088bee9a
😎 Deploy Preview https://deploy-preview-1801--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sdahlbac sdahlbac mentioned this pull request Oct 13, 2025
Closed
@erikgb erikgb requested a review from Copilot October 13, 2025 06:29
@erikgb
Copy link
Member

erikgb commented Oct 13, 2025

/cc

@cert-manager-prow cert-manager-prow bot requested a review from erikgb October 13, 2025 06:29
Copilot AI reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation to recommend using reloader instead of wave for automatically restarting deployments when mounted secrets change, addressing that wave appears to be no longer maintained.

  • Replaces the recommendation from wave to reloader in certificate documentation
  • Updates the URL to point to the reloader documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

erikgb
erikgb reviewed Oct 13, 2025
View reviewed changes
@erikgb
Copy link
Member

erikgb commented Oct 13, 2025

/label tide/merge-method-squash

@cert-manager-prow cert-manager-prow bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 13, 2025
@sdahlbac @erikgb
Update content/docs/usage/certificate.md
130aa10 
apply suggestion

Co-authored-by: Erik Godding Boye <egboye@gmail.com>
Signed-off-by: Simon Dahlbacka <simon.dahlbacka@fellowmind.fi>
@erikgb
Copy link
Member

erikgb commented Oct 13, 2025

❓ should I have been changing the text in the old doc versions too?

No, we usually don't do that. Thanks for asking.

erikgb
erikgb reviewed Oct 13, 2025
View reviewed changes
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdahlbac!

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@cert-manager-prow cert-manager-prow bot merged commit 7d8fabf into cert-manager:master Oct 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb erikgb left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doc: Recommend stakater instead of wave to handle private key rotation rollout

2 participants

@sdahlbac @erikgb