Skip to content

Conversation

@wallrj-cyberark
Copy link
Member

@wallrj-cyberark wallrj-cyberark commented Oct 7, 2025

Preview:

Part of: cert-manager/cert-manager#8113

These changes were carried out according to the release-notes sections of the release process:

I used the cert-manager release-notes tool that I'm developing in #1785 and added some narrative with the help of gpt-5-mini.

  • Populate release-notes-1.19.md with major themes and highlights
  • Populated the upgrade notes page
  • Add categorized changes sections: Feature, Bug or Regression, Other
  • Add contributor acknowledgements and notes about upgrades and fixes
  • Updated cert-manager version variable
  • Updated CLI and API reference docs

The changes will be merged into the release-next branch, which will later be merged into the main branch when we've published the release.

- Populate release-notes-1.19.md with major themes and highlights
- Add categorized changes sections: Feature, Bug or Regression, Other
- Add contributor acknowledgements and notes about upgrades and fixes

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2025
@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bbf565a
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/68e541064cd5bf0008c6d49e
😎 Deploy Preview https://deploy-preview-1792--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@wallrj-cyberark wallrj-cyberark changed the title cert-manager 1.19.0 release notes Release notes for cert-manager v1.19.0 Oct 7, 2025
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@cert-manager-prow cert-manager-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2025
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
</td>
<td>
<p>The IP address or hostname of an authoritative DNS server supporting RFC2136 in the form host:port. If the host is an IPv6 address it must be enclosed in square brackets (e.g [2001:db8::1]) ; port is optional. This field is required.</p>
<p>The IP address or hostname of an authoritative DNS server supporting RFC2136 in the form host:port. If the host is an IPv6 address it must be enclosed in square brackets (e.g [2001:db8::1]); port is optional. This field is required.</p>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a weird whitespace character here which I had to manually delete. It was being picked up by eslint:

But it seems to be added at least 5 years ago:


- TODO

{/* BEGIN contributors */}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These template variables are used by a new cert-manager-release-notes tool that I'm developing in:

| Release | Release Date | End of Life | [Supported Kubernetes / OpenShift Versions][s] | [Tested Kubernetes Versions][test] |
|:--------:|:------------:|:---------------:|:----------------------------------------------:|:----------------------------------:|
| [1.19][] | Oct 7, 2025 | Release of 1.21 | 1.31 → 1.34 / 4.18 → 4.19 | 1.31 → 1.34 |
| [1.20][] | Feb 10, 2026 | Release of 1.21 | 1.31 → 1.34 / 4.18 → 4.19 | 1.31 → 1.34 |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first Tuesday, four months from October 7, 2025.

Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've left 2 minor comments. Feel free to unhold.

/hold
/lgtm

---

Before upgrading cert-manager from 1.18 to 1.19, please read the following important notes about breaking changes in 1.19:
Before upgrading cert-manager from 1.18 to 1.19, please read the following important notes about breaking changes in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before upgrading cert-manager from 1.18 to 1.19, please read the following important notes about breaking changes in
Before upgrading cert-manager from 1.18 to 1.19, please read the following important notes about breaking changes:

<em>
<a href="#meta.cert-manager.io/v1.ObjectReference">ObjectReference</a>
</em>
<em>github.com/cert-manager/cert-manager/pkg/apis/meta/v1.IssuerReference</em>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the generator no longer generates html links using anchors. It now shows like this:

Image

Not a massive deal. Would it be easy to fix that right away, or does it require further investigation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll investigate that in another PR.


### Observability, Reliability, and Maintenance
- There is a new Prometheus metric called `certmanager_certificate_challenge_status`.
- POTENTIALLY BREAKING: A high cardinality label, called `path`, was removed from the `certmanager_acme_client_request_count` and `certmanager_acme_client_request_duration_seconds` metrics. It is replaced with a new bounded cardinality label called `action`. This may require updates to dashboards and alerts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It would be good to show an example before/after, but I guess users can open the corresponding issue, which might already contain an example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. But I'm running out of time to get this merged before EOD. I'll revisit in another PR.

@cert-manager-prow cert-manager-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2025
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@wallrj
Copy link
Member

wallrj commented Oct 7, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wallrj-cyberark
Copy link
Member Author

/unhold

@cert-manager-prow cert-manager-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
@cert-manager-prow cert-manager-prow bot merged commit 342db6a into cert-manager:release-next Oct 7, 2025
7 checks passed
@wallrj-cyberark wallrj-cyberark deleted the release-next-cert-manager-1.19.0 branch October 7, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants