Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Sep 13, 2025

As I don't have any local setup for the tools used in this project, I need another environment to work in. This will probably be the case for other contributors to this project. The PR adds a simple devcontainer configuration that should allow contributors to spin up an online environment ready to work on this project.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2025
@netlify
Copy link

netlify bot commented Sep 13, 2025

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 73717d5
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/68e56dbdf2f07b0008d7b354
😎 Deploy Preview https://deploy-preview-1768--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@erikgb erikgb requested a review from Copilot September 13, 2025 12:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a devcontainer configuration to enable contributors to work on the project in a standardized development environment without requiring local tool setup. The configuration provides a Node.js 22 environment with necessary dependencies and VS Code extensions.

  • Adds devcontainer configuration with Node.js 22 base image
  • Configures automatic installation of project dependencies and Netlify CLI
  • Sets up VS Code extensions for linting, formatting, and Markdown editing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@erikgb
Copy link
Member Author

erikgb commented Sep 15, 2025

/cc @inteon

@cert-manager-prow cert-manager-prow bot requested a review from inteon September 15, 2025 19:59
@erikgb
Copy link
Member Author

erikgb commented Sep 17, 2025

/cc @maelvls

Copy link
Member

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a good idea, yes.
But I haven't tested it....I don't know how to.
I suggest adding a paragraph about this to https://github.com/cert-manager/website?tab=readme-ov-file#website-development-tooling before we merge it or in a followup PR if you prefer.

@cert-manager-prow cert-manager-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2025
@erikgb
Copy link
Member Author

erikgb commented Oct 7, 2025

I suggest adding a paragraph about this to https://github.com/cert-manager/website?tab=readme-ov-file#website-development-tooling

Great suggestion! With a little help from ChatGPT, I've added a new section to this document. I have tested the devcontainer in GitHub Codespaces. Maybe you are a VSCode user, @wallrj? I am not, so I have not tested the docs from ChatGPT, but it looks sane. 😆

@erikgb erikgb requested a review from Copilot October 7, 2025 19:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb requested a review from Copilot October 7, 2025 19:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@erikgb erikgb requested a review from wallrj-cyberark October 7, 2025 19:49
@wallrj-cyberark
Copy link
Member

I suggest adding a paragraph about this to https://github.com/cert-manager/website?tab=readme-ov-file#website-development-tooling

Great suggestion! With a little help from ChatGPT, I've added a new section to this document. I have tested the devcontainer in GitHub Codespaces. Maybe you are a VSCode user, @wallrj? I am not, so I have not tested the docs from ChatGPT, but it looks sane. 😆

Thanks @erikgb

As I understand it, you've tested this devcontainer in the web based GitHub codespaces, but not in the VSCode app. I'm not a VSCode user either. Let's merge it and see what feedback we get.

@wallrj
Copy link
Member

wallrj commented Oct 9, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj, wallrj-cyberark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@cert-manager-prow cert-manager-prow bot merged commit f9a7583 into cert-manager:master Oct 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants