-
Notifications
You must be signed in to change notification settings - Fork 375
Add devcontainer configuration #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a devcontainer configuration to enable contributors to work on the project in a standardized development environment without requiring local tool setup. The configuration provides a Node.js 22 environment with necessary dependencies and VS Code extensions.
- Adds devcontainer configuration with Node.js 22 base image
- Configures automatic installation of project dependencies and Netlify CLI
- Sets up VS Code extensions for linting, formatting, and Markdown editing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/cc @inteon |
|
/cc @maelvls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a good idea, yes.
But I haven't tested it....I don't know how to.
I suggest adding a paragraph about this to https://github.com/cert-manager/website?tab=readme-ov-file#website-development-tooling before we merge it or in a followup PR if you prefer.
d2685d8 to
b0cbe21
Compare
Great suggestion! With a little help from ChatGPT, I've added a new section to this document. I have tested the devcontainer in GitHub Codespaces. Maybe you are a VSCode user, @wallrj? I am not, so I have not tested the docs from ChatGPT, but it looks sane. 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
b0cbe21 to
73717d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thanks @erikgb As I understand it, you've tested this devcontainer in the web based GitHub codespaces, but not in the VSCode app. I'm not a VSCode user either. Let's merge it and see what feedback we get. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj, wallrj-cyberark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As I don't have any local setup for the tools used in this project, I need another environment to work in. This will probably be the case for other contributors to this project. The PR adds a simple devcontainer configuration that should allow contributors to spin up an online environment ready to work on this project.