Merge master into release-next #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While $ is a good way to differentiate between a command and its output, it is best to leave it out whenever there is no output. This way, the user can copy the command by clicking the copy button on the rendered website without having to worry about the leading $ when pasting the command. This was already the case for some snippets. This change removes the leading $ for some more snippets. Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
This change replaces "bash" with "console" as the Markdown code fence keyword. This lets Markdown engines differentiate between the shell command and its output, with a leading $ (or # or >) denoting a command and the rest is just text output with no syntax highlighting. Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
Remove $ from bash code snippets
Markup shell session snippets as console
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Document new releases of istio-csr and trust-manager
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Fix release next link
cert-manager v1.15.2 release notes
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
…eate-namespace-from-helm-template fix: remove --create-namespace from helm template example
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Add more runtime config notes for istio-csr v0.11.0
cert-manager-prow
bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-1533--cert-manager.netlify.app/docs/installation/
I manually merged
origin/masterintorelease-next.Fixed the conflict that you currently can see in #1520: