Remove GetIssuerTypeIdentifier from Issuer API #186
+272
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
inteon
force-pushed
the
simplify_issuer_api_move_GetIssuerTypeIdentifier
branch
2 times, most recently
from
1a1ecef to
86ed14d
Compare
|
I don't have the right commit bits to move this along, but I'm a fan of simplifying the interface. Would it be feasible to remove |
cert-manager-prow
bot
added
the
needs-rebase
…s in our example Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
…roller initialisation Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
simplify_issuer_api_move_GetIssuerTypeIdentifier
branch
from
86ed14d to
89d6670
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now moved to the controller initialization.
Instead having to implement
GetIssuerTypeIdentifierfor each issuer type, we now just ask to provide theGroupResourcewhen intialising the controller. This makes the API more intuitive.Later (future PRs), we could use kubernetes discovery to discover the
GroupResourcebased on the installed CRDs.