Skip to content

Specify custom commonname for webhook dynamic authority #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Specify custom commonname for webhook dynamic authority #619

wants to merge 1 commit into from

Conversation

inteon
Copy link
Member

@inteon inteon commented Apr 23, 2025

Uses cert-manager/cert-manager#7680

Fixes #505

Customizes the commonname and labels used for the webhook certificate.

@inteon
specify custom commonname for webhook dynamic authority
282a208 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Apr 23, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2025
erikgb
erikgb reviewed Apr 23, 2025
View reviewed changes
go.mod
@@ -3,7 +3,7 @@ module github.com/cert-manager/approver-policy
go 1.23.0

require (
github.com/cert-manager/cert-manager v1.17.1
github.com/cert-manager/cert-manager v1.17.1-0.20250422102637-9b4a65aefbdc
Copy link
Contributor

@erikgb erikgb Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for the upcoming 1.17.2 patch release, or doesn't it matter? Or maybe not, then we would have to wait until 1.18.0 probably.

@cert-manager-prow
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameterize the name used in the managed-by label of the webhook CA Secret to distinguish it from the CA Secret created by cert-manager
2 participants
@inteon @erikgb