Add support for stamps #481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for stamping by copying stamp values into the task result meta, following the approach used by Celery's base backend.
- Adds a new skipped unit test to verify stamping support.
- Updates the DatabaseBackend's meta extraction function to incorporate stamps and stamped headers into the task metadata.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| t/unit/backends/test_database.py | Adds a unit test for stamping support (currently skipped). |
| django_celery_results/backends/database.py | Updates metadata extraction to incorporate stamping data. |
Comments suppressed due to low confidence (1)
t/unit/backends/test_database.py:553
- The test for stamped headers is currently skipped. Consider investigating an approach to inject stamped headers into the request so that stamping support is actively validated.
@pytest.mark.skip("Need to find how to inject stamped headers")
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
auvipy
requested changes
Jun 9, 2025
| @@ -550,6 +550,37 @@ def test_backend__task_result_meta_injection(self): | |||
| tr = TaskResult.objects.get(task_id=tid2) | |||
| assert json.loads(tr.meta) == {'key': 'value', 'children': []} | |||
|
|
|||
| @pytest.mark.skip("Need to find how to inject stamped headers") | |||
There was a problem hiding this comment.
mmmm.... not sure if we should merge this with this test only.... should we wait bit more?
There was a problem hiding this comment.
Yeah I agree this needs testing - I just couldn't work out how to actually go about setting the stamp on the request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480
Adds support for stamping by copying stamps into the result meta. This is the same approach Celery's base backend takes.
I wrote a test but it's currently marked as skipped, as I couldn't figure out how to set the stamps on the request. You can't set them directly on the
Requestobject and I wasn't sure if I could pass something into the_create_requesthelper to set them.