Skip to content

feat: bump doctrine cs to v13, slevomat cs to v8.16 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
"require": {
"php": "^8.3",
"doctrine/coding-standard": "^12.0",
"slevomat/coding-standard": "8.15",
"doctrine/coding-standard": "^13.0",
"slevomat/coding-standard": "^8.16",
"squizlabs/php_codesniffer": "^3.11.3"
},
"require-dev": {
Expand Down
6 changes: 3 additions & 3 deletions src/Cdn77/Sniffs/NamingConventions/ValidConstantNameSniff.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@

class ValidConstantNameSniff implements Sniff
{
public const CodeClassConstantNotMatchPattern = 'ClassConstantNotUpperCase';
public const CodeConstantNotMatchPattern = 'ConstantNotUpperCase';
private const PatternPascalCase = '\b([A-Z][a-zA-Z0-9]*?([A-Z][a-zA-Z0-9]*?)*?)\b';
public const string CodeClassConstantNotMatchPattern = 'ClassConstantNotUpperCase';
public const string CodeConstantNotMatchPattern = 'ConstantNotUpperCase';
private const string PatternPascalCase = '\b([A-Z][a-zA-Z0-9]*?([A-Z][a-zA-Z0-9]*?)*?)\b';

public string $pattern = self::PatternPascalCase;

Expand Down
10 changes: 5 additions & 5 deletions src/Cdn77/Sniffs/NamingConventions/ValidVariableNameSniff.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@

class ValidVariableNameSniff extends AbstractVariableSniff
{
public const CodeDoesNotMatchPattern = 'DoesNotMatchPattern';
public const CodeMemberDoesNotMatchPattern = 'MemberDoesNotMatchPattern';
public const CodeStringDoesNotMatchPattern = 'StringDoesNotMatchPattern';
private const PatternCamelCase = '\b([a-zA-Z][a-zA-Z0-9]*?([A-Z][a-zA-Z0-9]*?)*?)\b';
private const PatternCamelCaseOrUnused = '\b(([a-zA-Z][a-zA-Z0-9]*?([A-Z][a-zA-Z0-9]*?)*?)|_+)\b';
public const string CodeDoesNotMatchPattern = 'DoesNotMatchPattern';
public const string CodeMemberDoesNotMatchPattern = 'MemberDoesNotMatchPattern';
public const string CodeStringDoesNotMatchPattern = 'StringDoesNotMatchPattern';
private const string PatternCamelCase = '\b([a-zA-Z][a-zA-Z0-9]*?([A-Z][a-zA-Z0-9]*?)*?)\b';
private const string PatternCamelCaseOrUnused = '\b(([a-zA-Z][a-zA-Z0-9]*?([A-Z][a-zA-Z0-9]*?)*?)|_+)\b';

public string $pattern = self::PatternCamelCaseOrUnused;
public string $memberPattern = self::PatternCamelCase;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
*/
final class AlphabeticallyOrderedConstantsSniff implements Sniff
{
public const CodeIncorrectConstantOrder = 'IncorrectConstantOrder';
public const string CodeIncorrectConstantOrder = 'IncorrectConstantOrder';

public function register(): array
{
Expand Down
Loading