refactor: Theme & ThemeOptions #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the state of this? |
Hey, I want to do another once-over to make sure I made the two things consistent and to put an example file in as well to check against the typescript types. |
illusionalsagacity
force-pushed
the
theme-updates
branch
from
ba19bf4 to
bc8c204
Compare
illusionalsagacity
changed the title
- Makes the naming more consistent between the two (needs another check) - Re-order types to be defined in the same order in each module - Fixes the breakpoints function types on the theme - Removes the now unnecessary runtime overhead of ThemeHelpers.addBreakpoint - Add ThemeHelpers.addBreakpointDown function - Add ExampleTheme.res file to the repo
illusionalsagacity
force-pushed
the
theme-updates
branch
from
bc8c204 to
c748d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #219