Skip to content

Conversation

@hannesbrandt
Copy link
Collaborator

Do not mark functions in header files as 'static'.

Analogous to cburstedde/libsc#226, this PR removes the 'static' keyword from inline functions in p4est's .h files.

@cburstedde
Copy link
Owner

cburstedde commented Jul 28, 2025 via email

@hannesbrandt
Copy link
Collaborator Author

I've removed the @unused@ for the inline functions and updated their documentation. There are also some functions affected by this PR that did not have the @unused@ in their documentation and are currently undocumented, which leads to a doxygen warning. Should I add documentation for these functions as well?

@cburstedde
Copy link
Owner

cburstedde commented Jul 29, 2025 via email

@cburstedde
Copy link
Owner

Thanks so much!

@cburstedde cburstedde merged commit 9eea786 into cburstedde:develop Jul 31, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants