IPv6 support and Python 3 conversion #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces support to Python 3, since Python 2 will deprecated in January 1st 2020. More info here: https://www.python.org/doc/sunset-python-2/ This Python 3 conversion breaks compatibility with Python 2 but since Python 2 will be deprecated, I see no issue with that. Another update this is introducing is ipv6 support since I started getting my ip in v6 format from the ifconfig providers. There is a new config entry `subdomains6` for configuring the ipv6 domains that will be updated if the returned ip is ipv6. With ipv6, the script will update either ipv6 or ipv4 depending on the value returned by the provider. The usage of the script remains the same. Other changes made: * Use `print()` function instead of the `print` statement * Better readability by using f-string * Use the json object directly from `requests`instead of parsing the content with the `json` module * Add function to check for ipv6 * Add `subdomains6`` to config got ipv6 subdomains * Incresed verbosity option
* Add option for the script to repeat itself after N seconds * Add a Dockerfile so that this could be run inside docker
This is in practice a complete rewrite of the application. Configuration is simplified and the execution can create a record if it does not exist. It supports IPv6 if the IP Lookup Service supports it too. There is no distintion between IPv4 and IPv6 in the configuration, this should be all abstracted by the application.
Update app to work with the latest Gandi API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support to Python 3, since Python 2 will
deprecated in January 1st 2020.
More info here: https://www.python.org/doc/sunset-python-2/
This Python 3 conversion breaks compatibility with Python 2
but since Python 2 will be deprecated, I see no issue with that.
Another update this is introducing is ipv6 support since I started
getting my ip in v6 format from the ifconfig providers.
There is a new config entry
subdomains6for configuring the ipv6domains that will be updated if the returned ip is ipv6.
With ipv6, the script will update either ipv6 or ipv4 depending on
the value returned by the provider.
The usage of the script remains the same.
Other changes made:
print()function instead of theprintstatementrequestsinstead of parsing thecontent with the
jsonmodule