Skip to content

fix: condition on the creation of the kms key #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

schniber
Copy link

@schniber schniber commented Jun 6, 2025

Description

this PR fixes #1278

Note: The whole PR is used as commit message.

Migrations required

No

Verification

I did deploy this module with both options, i.e. enable_managed_kms_key = true and enable_managed_kms_key = false to validate the fix

@schniber schniber requested review from npalm and kayman-mk as code owners June 6, 2025 00:25
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Hey @schniber! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@schniber
Copy link
Author

schniber commented Jun 6, 2025

@npalm : Hey, is it possible to peer review this ?
Happy to iterate based on your inputs.

Bests.

@schniber
Copy link
Author

Hey @kayman-mk,

Any chance of approving this after your review ?

Thanks a lot.

Bests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan fails if KMS key is being created at the same time as the module
2 participants