-
-
Notifications
You must be signed in to change notification settings - Fork 340
docs: add example configuration for Windows-based runners #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example configuration for Windows-based runners #1268
Conversation
Hey @zillemarco! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
Hi @kayman-mk 👋 Here you can finally find the docs and examples we had talked about in #1233 🙂 Since I extracted the example from our setup, that's still based on the version |
What do you think about moving this to a new example in Thanks for sharing your configuration. |
That's a good idea @kayman-mk, I agree. Only one thing I'd like to check: those examples are not really deployed, right? Because we'd need to create the Windows AMI for that to work otherwise. If instead those are just checked with, I don't know, |
Placeholders work fine. The examples are never deployed, right. |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
Sorry it took me this long to get back to this @kayman-mk 🙇 Could you please have a look at the changes and at the pipelines that are failing but I'm not really sure why? 🙏 Thanks a lot 🙂 |
Currently running this on our company CI infrastructure on AWS. Very good guide and mostly seems to work. After updating the GitLab Runner version and rebuilding the AMI, you have to update the AMI ID in the module as well. AWS generates a new ID for each AMI build apparently. Also had some issues with docker commands during Windows AMI build failing due to |
Hey @zillemarco - thank you so much for doing this! I've managed to get a windows runner in our infrastructure thanks to your help. A couple of things that I noticed:
Thanks again, really appreciate all the work you did on this! |
Thanks a lot @nexonen 🙇 I must share this appreciation with @RicePatrick who helped me a ton while working on our setup 🙂
Good call, I'll fix this.
Maybe AWS doesn't have those instance types available in the region you're deplying to? 🤔
I'll try without, but when I first set up the runners for out infra this was necessary 🤷 Maybe things changed in the meantime 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, guys! Makes the Windows setup a lot easier.
@zillemarco This PR can be merged? I will check the workflows. |
@kayman-mk yup, should be good to merge now that the workflows passed 👍 |
Added an example configuration to use the module to set up Windows-based runners and an example on how to create a custom Windows AMI usable with the configuration.