Skip to content

Moodle 405 stable runtest fixes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SashaAnastasi
Copy link

No description provided.

@SashaAnastasi
Copy link
Author

This failure is caused by ACPu being assumed disabled in the runtest. ACPu is disabled on NZEL servers.
It wasn't failing before because the assertion, being placed after an expectException, wasn't actually running.
Suggested fix is to disable ACPu in the runtest container.

@Peterburnett
Copy link
Contributor

It looks like we are still seeing CI failures here on the GA bots, likely due to some difference in containers or similar to do with APCu. My recommendation here is that we move the tests over to use 'file' instead of 'apcu' so the test environment is consistent everywhere, after which the tests should be green here. Functional change to the boolean logic looks good

@SashaAnastasi
Copy link
Author

The suggestion makes sense. I'll add a commit to reflect this.

@danmarsden danmarsden merged commit cd29909 into catalyst:MOODLE_405_STABLE Mar 5, 2025
7 checks passed
@danmarsden
Copy link
Member

merging this in for now to get our tests passing... @Peterburnett feel free to add further commits on top if you want to see it implement some improvements to tests!

@SashaAnastasi SashaAnastasi deleted the MOODLE_405_STABLE-runtest_fixes branch March 5, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants