Skip to content

fix: harden TLS configuration to disable weak cipher suites #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2025
Merged

fix: harden TLS configuration to disable weak cipher suites #119

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14f2bba
Initial plan
Copilot Oct 30, 2025
40b9532
Enhance TLS security configuration with additional hardening
Copilot Oct 30, 2025
8e61e99
Refactor TLS tests to use helper function and eliminate duplication
Copilot Oct 30, 2025
4dff9d9
Delete service/proxy_tls_test.go
nomeguy Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion service/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,16 +306,26 @@ func Start() {
server := &http.Server{
Addr: fmt.Sprintf(":%d", gatewayHttpsPort),
TLSConfig: &tls.Config{
// Minimum TLS version 1.2, TLS 1.3 is automatically supported
MinVersion: tls.VersionTLS12,
// Prefer server's cipher suite order for better security
PreferServerCipherSuites: true,
// Secure cipher suites for TLS 1.2 (excluding 3DES to prevent Sweet32 attack)
// TLS 1.3 cipher suites are automatically configured by Go
CipherSuites: []uint16{
// Secure cipher suites for TLS 1.2 (excluding 3DES to prevent Sweet32 attack)
tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,
tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,
},
// Prefer strong elliptic curves
CurvePreferences: []tls.CurveID{
tls.X25519,
tls.CurveP256,
tls.CurveP384,
},
},
}

Expand Down