Add SameSite attribute and security flags to authentication cookies #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookies set by CasWAF lacked the SameSite attribute, causing browsers to apply inconsistent defaults and potentially exposing the application to CSRF attacks.
Changes
service/captcha.go: Updated
casdoor_captcha_tokencookieSameSite: http.SameSiteLaxModeHttpOnly: trueSecure: scheme == "https"(conditional on connection type)service/oauth.go: Updated
casdoor_access_tokencookieSameSite: http.SameSiteLaxModeHttpOnly: trueSecure: scheme == "https"(conditional on connection type)service/cookie_test.go: Added tests validating cookie security attributes for both HTTP and HTTPS contexts
Example
The
SameSite=Laxsetting prevents CSRF attacks while preserving cookie functionality for OAuth callbacks and top-level navigation.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.