-
-
Notifications
You must be signed in to change notification settings - Fork 61
Fully working project with RBAC, ABAC support #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hsluoyz review this pr. |
@romitkarmakar i personally feel that it will be good, if we don't create seperate a project for tests as mentioned here. It will help to get all the advantages of dynamic linking/loading along with having a good coverage. What do you think about this? |
No capital letters in file names. casbin-test instead of casbin-cpp-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is very valuable, but can the directory structure keep the same style of Casbin (golang)?
@techoner Thanks, I will refactor the code acccording to the go directory structure. |
@hsluoyz , @techoner can you review this PR ? |
@mnprtpsingh Sorry for the late reply, I think we can also test non-exported functions in DLL by statically linking .obj files to the test project. Having a separate test folder gives us better integration testing. |
Nice to know, you have completed the project, but I would like to point out some missing core elements without which a user cannot use this project to the fullest.
|
I am afraid that your expression evaluator cannot take generic functions with different return types and different arguments. You can refer to more generic evaluators here : issue #3 |
Thanks, @divypatel9881. This is a MVP. I will be adding the watcher and synced enforcer in the next commit. Currently, I am working on the expression evaluator and it is still in development phase, and I will surely try to integrate generic templates and reflection into it. |
basic policy enforcer, model adapter and built-in csv adapter has been added. Expression parsing is being done using recursive descent parsing tree as a replacement for govaluate package. Google tests has been included.