Skip to content

add optional kbld platform selection option in App/Package specs #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

cppforlife
Copy link
Contributor

What this PR does / why we need it:

Context

We would like to use platform configuration on PackageBuild so that only images (not image indexes) are included in the built Package.

kbld's configuration will be carried over to running App/Package but will be ignored as older kapp-controller/kbld do not interpret it.

Does this PR introduce a user-facing change?

- Add optional kbld platform configuration

Additional Notes for your reviewer:

  • I believe there needs to be a follow up commit in CLI to use updated kapp-controller package once new kapp-controller version is cut
Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

Platform can be specified on App/Package CRs. This passes through value to underlying kbld's platform flag.

...
- kbld:
    paths: [".imgpkg/images.yml", "config/"]
    platform: "linux/amd64"
...

Signed-off-by: Dmitriy Kalinin <dkalinin@vmware.com>
Signed-off-by: João Pereira <joao.pereira@broadcom.com>
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @joaopapereira (since you added the generated code) if the rest looks good to you, I will merge it.

@joaopapereira joaopapereira merged commit 5a51bb2 into develop May 6, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this to Closed in Carvel May 6, 2025
@joaopapereira
Copy link
Member

given that you approved it I do not think we need the back and forth 😄

@joaopapereira joaopapereira deleted the kbld-platform branch May 6, 2025 14:51
@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants