fix: emit date change event to match React #1626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1625
What did you do?
@
items at the end of the attribute list i.e.@change="onChange"
dateChange
this event mimics thechange
event in the Carbon Reactsingle
kind andrange
kind. The v-model is different for each of these and I think separating the stories makes it a bit clearer.single
kind andrange
kind stories, show thedateChange
in the actions tabWhy did you do it?
See #1625 but basically there was no way to listen for changes for a range style date picker.
How have you tested it?
Via the storybook
Were docs updated if needed?