feat: cv-file-uploader update to current File object coming from event to internalFile #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to internalFile
|
Hi @davidnixon, could you please review this PR? Thank you! :) |
|
@felipebritor this looks OK to me. Can you have a look? |
davidnixon
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Just checking with @felipebritor because he knows this component really well.
|
Hello, @davidnixon . I'll test it tonight |
|
Looks good, @davidnixon . Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1607
What did you do?
Updated to current File object coming from event to internalFile so that if a file has been modified the internalFiles are updated
Why did you do it?
I have case where the user may add a .docx file with the same name but modified, and the current component is not updating with the modified file.
How have you tested it?
With local test environment
Were docs updated if needed?