fix: fix switch case for inline loading not working #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-angular-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Akshat55
requested changes
Jul 25, 2025
Comment on lines
37
to
38
| @switch (true) { | ||
| @case (state === InlineLoadingState.Inactive || state === InlineLoadingState.Active) { |
There was a problem hiding this comment.
We can probably just use a @if/else if condition instead. If you want to continue to use switch case, you can create a template for the content of state === InlineLoadingState.Inactive || state === InlineLoadingState.Active condition and use that condition for both case.
There was a problem hiding this comment.
Yeah, fair. I've switched to if else because it is less hidden than working that into a condition.
| <div | ||
| class="cds--loading cds--loading--small" | ||
| [ngClass]="{ | ||
| 'cds--loading--stop': state === InlineLoadingState.Inactive | ||
| 'cds--loading--stop': state === InlineLoadingState.Inctive |
There was a problem hiding this comment.
Suggested change
| 'cds--loading--stop': state === InlineLoadingState.Inctive | |
| 'cds--loading--stop': state === InlineLoadingState.Inactive |
Comment on lines
67
to
68
| @switch(true) { | ||
| @case(state === InlineLoadingState.Inactive || state === InlineLoadingState.Active) { |
switch case compares the value in the case via === which does not work with || or &&
tom-wegener
force-pushed
the
fix-inline-loading-component
branch
from
e218bc2 to
6125962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch case compares the value in the case via === which does not work with || or &&
inline loading did not work since the switch case had some problems but it should be fixed now
Found it while doing visual tests for #3162
Changelog
Changed