Skip to content

Move to standalone components #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

tom-wegener
Copy link

Updates all components to standalone components

It got a bit big but I've tried to move all components to standalone components. My test-setup is a bit confused with the changes but it works with the tests and storybook.

Changelog

Changed

  • updates all components to standalone components
  • updates all tests to work with the standalone components
  • updates storybook to work with standalone components
  • keeps the module functionality

I'm on vacation for the next two weeks but will look into this from time to time.

@tom-wegener tom-wegener requested a review from a team as a code owner July 4, 2025 07:51
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 4d43533
🔍 Latest deploy log https://app.netlify.com/projects/carbon-components-angular/deploys/686787e6d1c972000808354d
😎 Deploy Preview https://deploy-preview-3155--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for carbon-angular-next ready!

Name Link
🔨 Latest commit 4d43533
🔍 Latest deploy log https://app.netlify.com/projects/carbon-angular-next/deploys/686787e6cfcf55000876a555
😎 Deploy Preview https://deploy-preview-3155--carbon-angular-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

exports: [
Accordion,
AccordionItem
],
imports: [
CommonModule,
IconModule
IconModule,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work, thank you for this!

Do we still need modules? I thought we wouldn't need to keep the Modules once we go standalone or is this for backwards compatibility?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to keep the modules for backwards compatibility since angular 18 still allows the functionality and I didn’t want to break my own apps by upgrading.

in the end we don’t need them anymore and I/we/soneone could look into the angular migrations to ease the transition from modules to standalone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants