-
Notifications
You must be signed in to change notification settings - Fork 313
Move to standalone components #3155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Move to standalone components #3155
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-angular-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
exports: [ | ||
Accordion, | ||
AccordionItem | ||
], | ||
imports: [ | ||
CommonModule, | ||
IconModule | ||
IconModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing work, thank you for this!
Do we still need modules? I thought we wouldn't need to keep the Modules once we go standalone or is this for backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I wanted to keep the modules for backwards compatibility since angular 18 still allows the functionality and I didn’t want to break my own apps by upgrading.
in the end we don’t need them anymore and I/we/soneone could look into the angular migrations to ease the transition from modules to standalone.
Updates all components to standalone components
It got a bit big but I've tried to move all components to standalone components. My test-setup is a bit confused with the changes but it works with the tests and storybook.
Changelog
Changed
I'm on vacation for the next two weeks but will look into this from time to time.