capnpc-rust: make CLI plugin aware of default_parent_module
#568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enhances the `capnpc-rust` CLI plugin binary in order to make the default "parent module" value dynamic and controlled through an environment flag at runtime. It matches the behavior which is already available for `build.rs` scripts through `CompilerCommand::default_parent_module()`. This only affects the default value, which can be still overridden by `parentModule` schema annotations as usual. When using the Rust plugin through the `capnp` compiler, it is now possible to set the default parent module like this: ``` CAPNPC_RUST_DEFAULT_PARENT_MODULE="generated" capnp \ compile \ -orust:./src/generated/ \ --src-prefix=src/schema \ ./src/schema/poc.capnp ```
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
==========================================
- Coverage 51.64% 50.64% -1.00%
==========================================
Files 69 70 +1
Lines 33735 32239 -1496
==========================================
- Hits 17422 16329 -1093
+ Misses 16313 15910 -403 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the
capnpc-rustCLI plugin binary in order to make the default "parent module" value dynamic and controlled through an environment flag at runtime.It matches the behavior which is already available for
build.rsscripts throughCompilerCommand::default_parent_module().This only affects the default value, which can be still overridden by
parentModuleschema annotations as usual.When using the Rust plugin through the
capnpcompiler, it is now possible to set the default parent module like this: